-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bitcoin transaction fee assessment #557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getrawtransaction responses
fetches transactions from bitcoin-core
for a bitcoin transaction
get_tx_info function. Update an old test after bitcoin-core version change
instead of vbytes.
bitcoin-core client url
djordon
added
transaction library
Common library for handling transaction manipulation.
sbtc bootstrap signer
The sBTC Bootstrap Signer.
labels
Sep 24, 2024
cylewitruk
reviewed
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions, comments and suggestions :)
cylewitruk
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sbtc bootstrap signer
The sBTC Bootstrap Signer.
transaction library
Common library for handling transaction manipulation.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of #552 but it does not close it.
This stuff will likely move to the signer crate, just not right in this PR.
Changes
sbtc
crate integration tests are run in CI.BitcoinCoreClient
for fetching transaction data that includes the transaction's fee. This new function,get_tx_info
uses bitcoin-core'sgetrawtransaction
RPC with a verbosity of 2, which is available in v25 and later.in_active_chain
field from theGetTxResponse
struct. It was only ever populated when theBlockHash
was given as input, and we have another function that is better now.Testing Information
This PR adds an integration test for the new bitcoin-core client method and unit tests for the functions that apportion request fees. It also ensures integration tests in the
sbtc
crate get run.Checklist: